Extract io.trino.testing.containers into a separate module#10878
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Feb 3, 2022
Merged
Extract io.trino.testing.containers into a separate module#10878sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
kokosing
approved these changes
Feb 1, 2022
aczajkowski
approved these changes
Feb 1, 2022
linzebing
force-pushed
the
container-module
branch
from
0ff6869 to
17f2dd1
Compare
arhimondr
approved these changes
Feb 1, 2022
Contributor
There was a problem hiding this comment.
Could you please try to remove this dependency and see whether you still need the TestDummy?
Member
Author
There was a problem hiding this comment.
It's needed for CI/CD otherwise it will complain no tests to run. The failure doesn't complain dependency issue. It's also seen elsewhere https://github.com/trinodb/trino/blob/master/core/trino-server-main/src/test/java/io/trino/server/TestDummy.java and https://github.com/trinodb/trino/blob/master/testing/trino-testing-kafka/src/test/java/io/trino/server/TestDummy.java
linzebing
force-pushed
the
container-module
branch
from
17f2dd1 to
3ae884d
Compare
linzebing
force-pushed
the
container-module
branch
from
3ae884d to
19e4c8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the exchange spooling PR #10823, we realized that our dependency story is clearer if we extract
io.trino.testing.containersinto a separate module:trino-mainhas a testTestDeduplicatingDirectExchangeBufferthat depends ontrino-exchange, thereforetrino-exchangecan't depend ontrino-mainandtrino-testing. However, we need to have a MinIO-based test utility that can be used to test S3-based spooling, which need to depend on the containerio.trino.testing.containers.Minio, and this results in circular dependency. Therefore, we think it's better to extractio.trino.testing.containersinto a separate module.