Remove manual creation of io.trino.metadata.Catalog in tests#10875
Merged
dain merged 1 commit intotrinodb:masterfrom Feb 3, 2022
Merged
Remove manual creation of io.trino.metadata.Catalog in tests#10875dain merged 1 commit intotrinodb:masterfrom
dain merged 1 commit intotrinodb:masterfrom
Conversation
dain
force-pushed
the
remove-manual-catalog-creation
branch
from
1767d05 to
e0f52c5
Compare
Catalog is a deep internal API and use if this interface in tests makes refatoring of the engine difficult. Instead LocalQueryRunner is used to add catalogs and fetch internal services.
dain
force-pushed
the
remove-manual-catalog-creation
branch
from
e0f52c5 to
9a1b0c8
Compare
electrum
approved these changes
Feb 3, 2022
core/trino-main/src/test/java/io/trino/execution/BaseDataDefinitionTaskTest.java
Show resolved
Hide resolved
| queryStateMachine = stateMachine(transactionManager, createTestMetadataManager(), new AllowAllAccessControl(), testSession); | ||
| } | ||
|
|
||
| @AfterMethod |
Member
Author
There was a problem hiding this comment.
This needs to be after method to match the before method above, but I added the always true
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog is a deep internal API and use if this interface in tests makes refatoring of the engine difficult. Instead LocalQueryRunner is used to add catalogs and fetch internal services.
No release notes needed for this.