Fix information_schema with IS NOT NULL predicate#10867
Merged
findepi merged 1 commit intotrinodb:masterfrom Feb 1, 2022
Merged
Conversation
kokosing
approved these changes
Jan 31, 2022
sopel39
reviewed
Feb 1, 2022
Member
There was a problem hiding this comment.
so this assertion was not correct? why?
Member
There was a problem hiding this comment.
why it was added in first place?
Member
There was a problem hiding this comment.
why it was added in first place?
Member
Author
Member
There was a problem hiding this comment.
Ah, I see. I copied that section from somwhere. If you grep though code checkState(!range.isAll()); // Already checked you will find many similar places. I wonder if all of them are correct (some look correct)
Member
Author
There was a problem hiding this comment.
i checked all of them and the only invalid one is covered by #9885
findepi
force-pushed
the
findepi/fix-information-schema-with-is-not-null-predicate-739149
branch
from
1407287 to
73fef85
Compare
sopel39
approved these changes
Feb 1, 2022
Closed
findepi
deleted the
findepi/fix-information-schema-with-is-not-null-predicate-739149
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10861