Merged
Conversation
Change all properties from an indexed map to a simple collection
electrum
approved these changes
Jan 31, 2022
core/trino-main/src/main/java/io/trino/metadata/PropertyUtil.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/PropertyUtil.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
cleanup-property-management
branch
4 times, most recently
from
d25aa52 to
4965299
Compare
Consolidate logic to getNullableProperties Add simple wrapper method to filter null properties from getNullableProperties Extract property evaluation to a utility class Simplify the complex error message generation logic Remove Properties class which is easily confused with JVM class
This abstraction is overly complex for the two uses, and is much simpler when inlined
dain
force-pushed
the
cleanup-property-management
branch
from
4965299 to
01acc3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.