[WIP] Add comments at column level for views#10854
Closed
shandeep00 wants to merge 1 commit intotrinodb:masterfrom
Closed
[WIP] Add comments at column level for views#10854shandeep00 wants to merge 1 commit intotrinodb:masterfrom
shandeep00 wants to merge 1 commit intotrinodb:masterfrom
Conversation
Contributor
Author
|
@ebyhr was able to add comment to viewdefiniton but I am struck at showing this comment in |
ebyhr
reviewed
Jan 31, 2022
| throw semanticException(COLUMN_NOT_FOUND, statement, "Column does not exist: " + columnName); | ||
| } | ||
|
|
||
| accessControl.checkCanSetColumnComment(session.toSecurityContext(), tableName); |
Member
There was a problem hiding this comment.
was able to add comment to viewdefiniton
The comment isn't yet stored to HMS as far as I checked. How did you confirm the comment?
Member
|
Superseded by #13800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10705