Skip to content

Cleanup CI jobs for modules#10838

Merged
electrum merged 1 commit intotrinodb:masterfrom
electrum:ci
Jan 28, 2022
Merged

Cleanup CI jobs for modules#10838
electrum merged 1 commit intotrinodb:masterfrom
electrum:ci

Conversation

@electrum
Copy link
Copy Markdown
Member

  • simplify ORC and Parquet
  • combine Elasticsearch jobs
  • split out unrelated connectors
  • split out longer modules into separate job

@cla-bot cla-bot bot added the cla-signed label Jan 28, 2022
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will increase CI wall time.

Each job pays a constant overhead of compilation + some preparation which we were able to amortize by combining short modules and save up on CI minutes.

@electrum
Copy link
Copy Markdown
Member Author

The increase in usage is minimal. Connectors have about 90 seconds overhead. The goal is to keep things simple and reduce wall time for long running jobs. If you're working on something that's at the end of one of these combined modules, you have wait much longer to see if it succeeds or fails.

- simplify ORC and Parquet
- combine Elasticsearch jobs
- split out unrelated connectors
- split out longer modules into separate job
@electrum
Copy link
Copy Markdown
Member Author

Resource usage and wall time are actually separate goals. Given our concurrency limit, we actually need to break up the larger jobs in order better utilize our concurrency and decrease wall time. We also need to decrease overall usage, but there are better ways to do that, such as test avoidance.

@electrum electrum requested a review from hashhar January 28, 2022 18:01
@hashhar
Copy link
Copy Markdown
Member

hashhar commented Jan 28, 2022

we actually need to break up the larger jobs in order better utilize our concurrency and decrease wall time

Agreed. There is an idea to split the monolithic numbered product test suites into more targeted ones (e.g. suite-postgresql, suite-sqlserver etc.) so that we can run them selectively as well.

test avoidance

#10323

Also for reference wall time is impacted but a very small fraction of total runtime so it shouldn't matter. (~5mins out of ~1.5h)

@electrum electrum merged commit 0b825b8 into trinodb:master Jan 28, 2022
@electrum electrum deleted the ci branch January 28, 2022 19:44
@github-actions github-actions bot added this to the 370 milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants