Run HttpRemoteTask#sendUpdate in separate thread#10836
Closed
sopel39 wants to merge 1 commit intotrinodb:masterfrom
Closed
Run HttpRemoteTask#sendUpdate in separate thread#10836sopel39 wants to merge 1 commit intotrinodb:masterfrom
sopel39 wants to merge 1 commit intotrinodb:masterfrom
Conversation
Sending update is potentially expensive operation therefore it should be run from separate thread. This fixes bug introduced by trinodb@613bd2f
Member
Author
|
orignal commit that introduced executor fe57b0f |
|
Would be great to add @riteshvaryani as an author. |
JamesRTaylor
approved these changes
Jan 28, 2022
|
We've verified this fixed the regression from 359 -> 360. We'll confirm on 365 soon too. |
akashkatipally
approved these changes
Jan 28, 2022
Member
|
raunaqmorarka
approved these changes
Jan 28, 2022
Member
|
@sopel39 is it testable? |
Member
Author
|
Closing in favor of #10839 |
Member
Author
I doubt so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending update is potentially expensive operation
therefore it should be run from separate thread.
This fixes bug introduced by
613bd2f