Skip to content

Document ALTER MATERIALIZED VIEW SET PROPERTIES#10835

Merged
hashhar merged 1 commit intotrinodb:masterfrom
jhlodin:jl/sql-set-properties
Feb 3, 2022
Merged

Document ALTER MATERIALIZED VIEW SET PROPERTIES#10835
hashhar merged 1 commit intotrinodb:masterfrom
jhlodin:jl/sql-set-properties

Conversation

@jhlodin
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin commented Jan 27, 2022

Document changes discussed in #10774

@cla-bot cla-bot bot added the cla-signed label Jan 27, 2022
@jhlodin jhlodin added the docs label Jan 27, 2022
sunningCGo
sunningCGo reviewed Jan 27, 2022
View reviewed changes
@jhlodin jhlodin force-pushed the jl/sql-set-properties branch from d934b0e to 1dd1d89 Compare January 28, 2022 04:47
@sunningCGo
Copy link
Copy Markdown

sunningCGo commented Jan 28, 2022

Will you be documenting the support of the DEFAULT keyword in the other six kinds of statements?

@hashhar
Copy link
Copy Markdown
Member

hashhar commented Jan 28, 2022

@jhlodin Please ping me/tag me once this looks ready to merge. I unfortunately don't have enough context to review this - I'll defer to @sunningCGo.

@hashhar hashhar removed their request for review January 28, 2022 05:59
@jhlodin
Copy link
Copy Markdown
Contributor Author

jhlodin commented Jan 28, 2022

Will you be documenting the support of the DEFAULT keyword in the other six kinds of statements?

I can as a follow-up PR once this language gets approved and merged. The most important inclusion is the ALTER MV SET PROPERTIES documentation.

@jhlodin jhlodin requested a review from sunningCGo January 31, 2022 17:47
sunningCGo
sunningCGo approved these changes Jan 31, 2022
View reviewed changes
Copy link
Copy Markdown

@sunningCGo sunningCGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please remember to document the support of DEFAULT in the other six kinds of statements as a follow-up.

@jhlodin jhlodin mentioned this pull request Jan 31, 2022
Open
@jhlodin
Copy link
Copy Markdown
Contributor Author

jhlodin commented Jan 31, 2022

Tracked documenting the support of DEFAULT keyword in this issue: #10869

Can we merge this PR?

@sunningCGo
Copy link
Copy Markdown

sunningCGo commented Jan 31, 2022

I don't have permission to merge things into trino but I think @mosabua does.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 31, 2022

I wish @sunningCGo .. can we get some help from @electrum @martint @hashhar @findepi maybe?

@ebyhr ebyhr requested a review from sopel39 February 1, 2022 02:12
@findinpath
Copy link
Copy Markdown
Contributor

findinpath commented Feb 1, 2022

Please do use different commits for:

  • set properties
  • materialized view

@jhlodin
Copy link
Copy Markdown
Contributor Author

jhlodin commented Feb 1, 2022 •
edited
Loading

Please do use different commits for:

* set properties

* materialized view

@findinpath do you mean separate commits for ALTER MATERIALIZED VIEW SET PROPERTIES and ALTER TABLE SET PROPERTIES?

findinpath
findinpath reviewed Feb 1, 2022
View reviewed changes
@findinpath
Copy link
Copy Markdown
Contributor

findinpath commented Feb 1, 2022 •
edited
Loading

@findinpath do you mean separate commits for ALTER MATERIALIZED VIEW SET PROPERTIES and ALTER TABLE SET PROPERTIES?

Yes.

@findinpath
Copy link
Copy Markdown
Contributor

findinpath commented Feb 1, 2022 •
edited
Loading

@sunningCGo I'm having a hard time to find a connector which supports the statement of altering the properties for materialized views.

Could you please document a simple test scenario for the functionality of dealing with this functionality?

Besides io.trino.plugin.clickhouse.ClickHouseClient#setTableProperties (Clickhouse connector) is there any other connector at the moment supporting setting table properties?

sopel39
sopel39 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % mind other comments

findinpath
findinpath reviewed Feb 1, 2022
View reviewed changes
@sunningCGo
Copy link
Copy Markdown

sunningCGo commented Feb 1, 2022 •
edited
Loading

@sunningCGo I'm having a hard time to find a connector which supports the statement of altering the properties for materialized views.

Support in Starburst Hive Connector is being added in https://github.com/starburstdata/starburst-enterprise/pull/4523.

Could you please document a simple test scenario for the functionality of dealing with this functionality?

There are some tests in https://github.com/starburstdata/starburst-enterprise/blob/2be54560b5dd8c1ccdc15fb72d5ba36d2d48a1ed/lib/starburst-redirection/src/test/java/com/starburstdata/presto/redirection/AbstractStarburstMaterializedViewsTest.java#L1165. These tests are part of the PR mentioned above.

Besides io.trino.plugin.clickhouse.ClickHouseClient#setTableProperties (Clickhouse connector) is there any other connector at the moment supporting setting table properties?

None that I am aware of.

@jhlodin jhlodin force-pushed the jl/sql-set-properties branch from 1dd1d89 to a0e7815 Compare February 1, 2022 22:32
@jhlodin jhlodin changed the title Document ALTER TABLE and MATERIALIZED VIEW SET PROPERTIES Document ALTER MATERIALIZED VIEW SET PROPERTIES Feb 1, 2022
hashhar
hashhar reviewed Feb 2, 2022
View reviewed changes
docs/src/main/sphinx/sql/alter-materialized-view.rst Outdated
Copy link
Copy Markdown
Member

@hashhar hashhar Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have some mechanism (a system table like system.metadata.table_properties?) to inspect available properties and their data types and default values?

Copy link
Copy Markdown
Member

@joshthoward joshthoward Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not. We could look at adding something like that in the future.

Copy link
Copy Markdown
Member

@hashhar hashhar Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10916

martint
martint reviewed Feb 2, 2022
View reviewed changes
@jhlodin jhlodin force-pushed the jl/sql-set-properties branch from a0e7815 to a88cfbb Compare February 2, 2022 19:29
@jhlodin jhlodin force-pushed the jl/sql-set-properties branch from a88cfbb to 09a1234 Compare February 2, 2022 20:57
@jhlodin jhlodin requested a review from hashhar February 2, 2022 20:57
@hashhar hashhar merged commit abedf46 into trinodb:master Feb 3, 2022
@github-actions github-actions bot added this to the 370 milestone Feb 3, 2022
@jhlodin jhlodin deleted the jl/sql-set-properties branch February 3, 2022 16:08
@jhlodin jhlodin mentioned this pull request Feb 3, 2022
Closed
@mosabua mosabua mentioned this pull request Feb 3, 2022
Merged
@jhlodin jhlodin mentioned this pull request Feb 11, 2022
Merged
@jhlodin jhlodin mentioned this pull request Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martint martint martint left review comments

@mosabua mosabua mosabua approved these changes

@sopel39 sopel39 sopel39 approved these changes

@hashhar hashhar hashhar approved these changes

@joshthoward joshthoward Awaiting requested review from joshthoward

+2 more reviewers

@findinpath findinpath findinpath left review comments

@sunningCGo sunningCGo sunningCGo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed docs

Milestone

370

Development

Successfully merging this pull request may close these issues.

8 participants

@jhlodin @sunningCGo @hashhar @mosabua @findinpath @martint @sopel39 @joshthoward