Skip to content

Fully migrate TopNOperator to WorkProcessorOperator#10832

Merged
sopel39 merged 1 commit intotrinodb:masterfrom
JunhyungSong:migrate-topnoperator-to-workprocessor
Jan 31, 2022
Merged

Fully migrate TopNOperator to WorkProcessorOperator#10832
sopel39 merged 1 commit intotrinodb:masterfrom
JunhyungSong:migrate-topnoperator-to-workprocessor

Conversation

@JunhyungSong
Copy link
Copy Markdown
Member

In order to reduce complexity, migrate TopNOperator to WorkProcessorOperator from AdapterWorkProcessorOperator.

No performance implication found.

AdapterWorkProcessorOperator

Benchmark (positionsPerPage) (topN) Mode Cnt Score Error Units
BenchmarkTopNOperator.topN 32 1 thrpt 60 16.917 ± 1.182 ops/s
BenchmarkTopNOperator.topN 32 100 thrpt 60 17.369 ± 0.517 ops/s
BenchmarkTopNOperator.topN 32 10000 thrpt 60 5.286 ± 0.058 ops/s
BenchmarkTopNOperator.topN 1024 1 thrpt 60 23.479 ± 0.387 ops/s
BenchmarkTopNOperator.topN 1024 100 thrpt 60 22.266 ± 0.267 ops/s
BenchmarkTopNOperator.topN 1024 10000 thrpt 60 7.306 ± 0.087 ops/s

WorkProcessorOperator

BenchmarkTopNOperator.topN 32 1 thrpt 60 18.566 ± 0.877 ops/s
BenchmarkTopNOperator.topN 32 100 thrpt 60 17.176 ± 0.400 ops/s
BenchmarkTopNOperator.topN 32 10000 thrpt 60 5.293 ± 0.110 ops/s
BenchmarkTopNOperator.topN 1024 1 thrpt 60 23.134 ± 0.496 ops/s
BenchmarkTopNOperator.topN 1024 100 thrpt 60 22.107 ± 0.410 ops/s
BenchmarkTopNOperator.topN 1024 10000 thrpt 60 7.293 ± 0.151 ops/s

@cla-bot cla-bot bot added the cla-signed label Jan 27, 2022
@JunhyungSong
Copy link
Copy Markdown
Member Author

JunhyungSong commented Jan 27, 2022

@sopel39 sopel39 merged commit 262d836 into trinodb:master Jan 31, 2022
@github-actions github-actions bot added this to the 370 milestone Jan 31, 2022
@JunhyungSong JunhyungSong deleted the migrate-topnoperator-to-workprocessor branch January 31, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants