Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ public class HiveConfig
{
private static final Splitter SPLITTER = Splitter.on(',').trimResults().omitEmptyStrings();

private boolean singleStatementWritesOnly;

private DataSize maxSplitSize = DataSize.of(64, MEGABYTE);
private int maxPartitionsPerScan = 100_000;
private int maxOutstandingSplits = 1_000;
Expand Down Expand Up @@ -164,6 +166,19 @@ public class HiveConfig
private boolean sizeBasedSplitWeightsEnabled = true;
private double minimumAssignedSplitWeight = 0.05;

public boolean isSingleStatementWritesOnly()
{
return singleStatementWritesOnly;
}

@Config("hive.single-statement-writes")
@ConfigDescription("Require transaction to be in auto-commit mode for writes")
public HiveConfig setSingleStatementWritesOnly(boolean singleStatementWritesOnly)
{
this.singleStatementWritesOnly = singleStatementWritesOnly;
return this;
}

public int getMaxInitialSplits()
{
return maxInitialSplits;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public class HiveConnector
private final ClassLoader classLoader;

private final HiveTransactionManager transactionManager;
private final boolean singleStatementWritesOnly;

public HiveConnector(
LifeCycleManager lifeCycleManager,
Expand All @@ -84,6 +85,7 @@ public HiveConnector(
List<PropertyMetadata<?>> analyzeProperties,
List<PropertyMetadata<?>> materializedViewProperties,
Optional<ConnectorAccessControl> accessControl,
boolean singleStatementWritesOnly,
ClassLoader classLoader)
{
this.lifeCycleManager = requireNonNull(lifeCycleManager, "lifeCycleManager is null");
Expand All @@ -104,6 +106,7 @@ public HiveConnector(
this.analyzeProperties = ImmutableList.copyOf(requireNonNull(analyzeProperties, "analyzeProperties is null"));
this.materializedViewProperties = requireNonNull(materializedViewProperties, "materializedViewProperties is null");
this.accessControl = requireNonNull(accessControl, "accessControl is null");
this.singleStatementWritesOnly = singleStatementWritesOnly;
this.classLoader = requireNonNull(classLoader, "classLoader is null");
}

Expand Down Expand Up @@ -196,7 +199,7 @@ public ConnectorAccessControl getAccessControl()
@Override
public boolean isSingleStatementWritesOnly()
{
return false;
return singleStatementWritesOnly;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ public static Connector createConnector(String catalogName, Map<String, String>
hiveAnalyzeProperties.getAnalyzeProperties(),
hiveMaterializedViewPropertiesProvider.getMaterializedViewProperties(),
hiveAccessControl,
injector.getInstance(HiveConfig.class).isSingleStatementWritesOnly(),
classLoader);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public class TestHiveConfig
public void testDefaults()
{
assertRecordedDefaults(recordDefaults(HiveConfig.class)
.setSingleStatementWritesOnly(false)
.setMaxSplitSize(DataSize.of(64, Unit.MEGABYTE))
.setMaxPartitionsPerScan(100_000)
.setMaxOutstandingSplits(1_000)
Expand Down Expand Up @@ -115,6 +116,7 @@ public void testDefaults()
public void testExplicitPropertyMappings()
{
Map<String, String> properties = new ImmutableMap.Builder<String, String>()
.put("hive.single-statement-writes", "true")
.put("hive.max-split-size", "256MB")
.put("hive.max-partitions-per-scan", "123")
.put("hive.max-outstanding-splits", "10")
Expand Down Expand Up @@ -191,6 +193,7 @@ public void testExplicitPropertyMappings()
.buildOrThrow();

HiveConfig expected = new HiveConfig()
.setSingleStatementWritesOnly(true)
.setMaxSplitSize(DataSize.of(256, Unit.MEGABYTE))
.setMaxPartitionsPerScan(123)
.setMaxOutstandingSplits(10)
Expand Down