Update example of mongodb.connection-url#10818
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jan 27, 2022
Merged
Conversation
mosabua
approved these changes
Jan 26, 2022
Member
|
fyi @kpayne |
ebyhr
reviewed
Jan 27, 2022
|
|
||
| connector.name=mongodb | ||
| mongodb.connection-url=protocol://user:pass@sample.host:27017/ | ||
| mongodb.connection-url=mongodb://user:pass@sample.host:27017/ |
Member
There was a problem hiding this comment.
This property accepts mongodb+srv too. That is why I approved protocol. Can we change to placeholder style? e.g. {protocol}
Member
There was a problem hiding this comment.
That works too.. we just have to maybe also link to the section below then.. since this is an example only
ebyhr
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.