Fix Jwt & OAuth2 authenticators seperation issue#10811
Merged
kokosing merged 1 commit intotrinodb:masterfrom Jan 31, 2022
Merged
Fix Jwt & OAuth2 authenticators seperation issue#10811kokosing merged 1 commit intotrinodb:masterfrom
kokosing merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
One important thing to notice: I've renamed |
kokosing
approved these changes
Jan 26, 2022
mat3e
approved these changes
Jan 26, 2022
Member
|
Typo "seperation" |
11xor6
approved these changes
Jan 27, 2022
Member
11xor6
left a comment
11xor6
left a comment
There was a problem hiding this comment.
LGTM, but the "retry" commit should be dropped.
Jwt & OAuth2 use the same classes in order to resolve JSON Web Keys (JWK) served over HTTP. Using both authenticators simultaneously resulted in a duplicated binding error which this commit fixes through a better binding separation.
lukasz-walkiewicz
force-pushed
the
fix-jwt-oauth-separation
branch
from
08023e7 to
0d5d0bc
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jwt & OAuth2 use the same classes in order to resolve JSON Web Keys (JWK)
served over HTTP. Using both authenticators simultaneously resulted in a
duplicated binding error which this commit fixes through a better
binding seperation.