Skip to content

Expose data files rows statistics fields in $manifests table#10809

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
findinpath:add-missing-fields-in-iceberg-manifests-table
Jul 9, 2022
Merged

Expose data files rows statistics fields in $manifests table#10809
ebyhr merged 1 commit intotrinodb:masterfrom
findinpath:add-missing-fields-in-iceberg-manifests-table

Conversation

@findinpath
Copy link
Copy Markdown
Contributor

@findinpath findinpath commented Jan 26, 2022 •
edited by ebyhr
Loading

Description

Expose org.apache.iceberg.ManifestFile data files rows fields which are not yet exposed in the $manifests metadata table.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Iceberg connector

How would you describe this change to a non-technical end user or system administrator?

Expose further fields in the $manifests Iceberg metadata table.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Iceberg
* Add `added_rows_count`, `existing_rows_count` and `deleted_rows_count` columns to `$manifests` table

@cla-bot cla-bot bot added the cla-signed label Jan 26, 2022
@findinpath findinpath marked this pull request as draft January 26, 2022 12:48
@findinpath findinpath mentioned this pull request Jan 26, 2022
Merged
@findinpath findinpath force-pushed the add-missing-fields-in-iceberg-manifests-table branch 2 times, most recently from 634abdb to 5099c98 Compare July 9, 2022 05:48
@findinpath findinpath marked this pull request as ready for review July 9, 2022 05:50
@findinpath findinpath requested review from ebyhr, electrum and lxynov July 9, 2022 05:50
@findinpath findinpath changed the title Expose further fields in $manifests metadata table Expose file row related fields in $manifests metadata table Jul 9, 2022
@findinpath findinpath force-pushed the add-missing-fields-in-iceberg-manifests-table branch from 5099c98 to 409ecd3 Compare July 9, 2022 06:02
@findinpath findinpath changed the title Expose file row related fields in $manifests metadata table Expose data files rows statistics fields in $manifests table Jul 9, 2022
ebyhr
ebyhr reviewed Jul 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update iceberg.rst?

@findinpath findinpath force-pushed the add-missing-fields-in-iceberg-manifests-table branch from 409ecd3 to 1146237 Compare July 9, 2022 06:16
@github-actions github-actions bot added the docs label Jul 9, 2022
@findinpath findinpath requested a review from ebyhr July 9, 2022 06:17
@ebyhr ebyhr merged commit 453a36a into trinodb:master Jul 9, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jul 9, 2022

Merged, thanks!

@ebyhr ebyhr mentioned this pull request Jul 9, 2022
Closed
@github-actions github-actions bot added this to the 390 milestone Jul 9, 2022
@colebow colebow mentioned this pull request Jul 11, 2022
Merged
@ebyhr ebyhr mentioned this pull request Jul 12, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

@electrum electrum Awaiting requested review from electrum

@lxynov lxynov Awaiting requested review from lxynov

Assignees

No one assigned

Labels

cla-signed docs

Milestone

390

Development

Successfully merging this pull request may close these issues.

2 participants

@findinpath @ebyhr