Fix Kudu tests to also run on MacOS#10802
Merged
hashhar merged 1 commit intotrinodb:masterfrom Feb 1, 2022
Merged
Conversation
grantatspothero
force-pushed
the
gn/fixKuduTestsOnMac
branch
from
d4af824 to
727f4f2
Compare
Praveen2112
reviewed
Jan 26, 2022
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
Praveen2112
reviewed
Jan 26, 2022
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
grantatspothero
commented
Jan 26, 2022
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
Praveen2112
reviewed
Jan 27, 2022
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
grantatspothero
force-pushed
the
gn/fixKuduTestsOnMac
branch
from
d52bf80 to
7606179
Compare
hashhar
approved these changes
Jan 28, 2022
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestingKuduServer.java
Outdated
Show resolved
Hide resolved
hashhar
approved these changes
Jan 31, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for getting this to work.
Please squash commits as Use ToxiProxy to forward traffic from host to kudu tablets + some description of why (the javadoc of TestingKuduServer maybe?)
grantatspothero
force-pushed
the
gn/fixKuduTestsOnMac
branch
2 times, most recently
from
5a88745 to
710aff6
Compare
hashhar
approved these changes
Jan 31, 2022
Kudu tablets needs to know the host/mapped port it will be bound to in order to configure --rpc_advertised_addresses. However when using non-fixed ports in testcontainers, we only know the mapped port after the container starts up. In order to workaround this, create a proxy to forward traffic from the host to the underlying tablets. Since the ToxiProxy container starts up *before* kudu, we know the mapped port when configuring the kudu tablets.
hashhar
force-pushed
the
gn/fixKuduTestsOnMac
branch
from
710aff6 to
f081d19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3415
See the comments for the ugly workaround, but the good news is I'm able to run the tests locally without fixed port mappings.
Going to try stress testing multiple instances of the tests and see what happens