Skip to content

Add documentation for db resource group manager#10771

Merged
phd3 merged 1 commit intotrinodb:masterfrom
posulliv:update-resource-groups-db-docs
Feb 2, 2022
Merged

Add documentation for db resource group manager#10771
phd3 merged 1 commit intotrinodb:masterfrom
posulliv:update-resource-groups-db-docs

Conversation

@posulliv
Copy link
Copy Markdown
Contributor

Co-authored-by: Pratham Desai prathamd94@gmail.com

Resolves #10742 and #4450

Copy link
Copy Markdown
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please check red build

@posulliv posulliv force-pushed the update-resource-groups-db-docs branch from d40afd0 to 9f16fa3 Compare January 25, 2022 21:59
@posulliv
Copy link
Copy Markdown
Contributor Author

@phd3 thanks for having a look! In this latest push, I also added an example. I took the existing example for the file based resource group and showed what the corresponding SQL would look like to create that same resource group config.

@posulliv posulliv requested a review from phd3 January 25, 2022 22:01
@posulliv posulliv force-pushed the update-resource-groups-db-docs branch from 9f16fa3 to dcfebb4 Compare January 26, 2022 15:12
Copy link
Copy Markdown
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @posulliv. The content looks good, I've added some comments.

Co-authored-by: Pratham Desai <prathamd94@gmail.com>
@posulliv posulliv force-pushed the update-resource-groups-db-docs branch from dcfebb4 to d921006 Compare February 2, 2022 00:54
@posulliv posulliv requested a review from phd3 February 2, 2022 00:55
@posulliv
Copy link
Copy Markdown
Contributor Author

posulliv commented Feb 2, 2022

@phd3 thank for all the comments! I have applied everything in the latest push.

@phd3 phd3 merged commit 8af5483 into trinodb:master Feb 2, 2022
@phd3
Copy link
Copy Markdown
Member

phd3 commented Feb 2, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 370 milestone Feb 2, 2022
@posulliv posulliv deleted the update-resource-groups-db-docs branch February 2, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Document DB backed resource group manager

2 participants