-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Simplify extensability of BaseHiveConnectorTest #10753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,12 +14,15 @@ | |
| package io.trino.plugin.hive; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import io.trino.testing.QueryRunner; | ||
|
|
||
| public class TestHivePipelinedExecutionConnectorTest | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what does "pipelined execution" mean here? it this is "test hive with defaults", let's call the class just
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah - effectively it is with defaults (no failure recovery). I will rename in a separate PR after this gets merged. |
||
| extends BaseHiveConnectorTest | ||
| { | ||
| public TestHivePipelinedExecutionConnectorTest() | ||
| @Override | ||
| protected QueryRunner createQueryRunner() | ||
| throws Exception | ||
| { | ||
| super(ImmutableMap.of()); | ||
| return BaseHiveConnectorTest.createHiveQueryRunner(ImmutableMap.of()); | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.