Support writing timestamp(0) as datetime type in ClickHouse#10751
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Jan 26, 2022
Merged
Support writing timestamp(0) as datetime type in ClickHouse#10751ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
Member
Author
hashhar
reviewed
Jan 25, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
The PR title sounds misleading. It seems we supported writing timestamp(0) but didn't have any validation (in fromTrinoTimestamp) to ensure that values which have higher precision are not allowed.
Looks good to me otherwise.
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
Member
Author
We didn't support creating such type. See https://github.com/trinodb/trino/pull/10751/files#diff-7ce7bdaa32b38505167fecaa1621f0e71d942c962a7f39c0cce4ea5e21ef0a1aR540-R542 |
ebyhr
force-pushed
the
ebi/clickhouse-timestamp
branch
from
1768293 to
4d7b6b6
Compare
hashhar
approved these changes
Jan 25, 2022
This was referenced Jan 26, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.