Include base credentials for Glue IAM role#10735
Merged
dain merged 1 commit intotrinodb:masterfrom Jan 24, 2022
Merged
Conversation
Glue AWS credentials with IAM role must include the base credentials if provided. This change matches the behavior of `TrinoS3FileSystem.createAwsCredentialsProvider`. However, there is a slight change to the previous contract. Like `TrinoS3FileSystem.createAwsCredentialsProvider`, `GlueHiveMetastore.getAwsCredentialsProvider` will prefer config `config.getAwsCredentialsProvider()`. Fixes trinodb#10726
Member
|
cc: @losipiuk (reminder about Glue CI) |
electrum
approved these changes
Jan 21, 2022
This was referenced Jan 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glue AWS credentials with IAM role must include the base credentials if provided. This change matches the behavior of
TrinoS3FileSystem.createAwsCredentialsProvider. However, there is a slight change to the previous contract. LikeTrinoS3FileSystem.createAwsCredentialsProvider,GlueHiveMetastore.getAwsCredentialsProviderwill prefer configconfig.getAwsCredentialsProvider().Fixes #10726