Skip to content

Document scheduling policy config property#10715

Merged
sopel39 merged 1 commit intotrinodb:masterfrom
rosewms:rw-scheduling-policy
Jan 26, 2022
Merged

Document scheduling policy config property#10715
sopel39 merged 1 commit intotrinodb:masterfrom
rosewms:rw-scheduling-policy

Conversation

@rosewms
Copy link
Copy Markdown
Contributor

@rosewms rosewms commented Jan 20, 2022

@cla-bot cla-bot bot added the cla-signed label Jan 20, 2022
@rosewms rosewms force-pushed the rw-scheduling-policy branch from 82b149a to 32f0214 Compare January 20, 2022 22:17
@rosewms rosewms requested a review from jhlodin January 20, 2022 22:18
Copy link
Copy Markdown
Contributor

@m57lyra m57lyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ahve a question...

@hashhar hashhar requested review from sopel39 and removed request for hashhar January 21, 2022 06:35
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To restore previous previous policy behavior

I think such comment makes sense only in release notes. Maybe here we should briefly enumerate all policies?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great, the info I have is based on the 368 release notes. I'd love to get some clarity on the specific policies @sopel39

@rosewms rosewms force-pushed the rw-scheduling-policy branch from 32f0214 to 4c609e8 Compare January 24, 2022 22:04
Copy link
Copy Markdown
Member

@sopel39 sopel39 Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Phased execution schedule maximizes cluster resource utilization and provides lowest query wall time. Stages are scheduled in such a sequence that they shouldn't become blocked because of inter-stage dependency?

The previous default value ``all-at-once``, schedules all the phases of a query at one time. -> The previous default value ``all-at-once``, schedules all the stage of a query at one time.

The ``legacy-phased`` value schedules phases of a query only when it can start processing them. -> The ``legacy-phased`` schedules stages in such a sequence that they shouldn't become blocked because of inter-stage dependency. Compared to ``phased`` scheduler, ``legacy-phased`` will try to minimize number of running stages and can increase query wall time

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very helpful, I have a new version for review. Thanks @sopel39

@rosewms rosewms force-pushed the rw-scheduling-policy branch from 4c609e8 to dcecdfa Compare January 25, 2022 18:06
@rosewms rosewms requested a review from sopel39 January 25, 2022 18:06
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It" -> "This policy"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"similar" -> "has similar"

@rosewms rosewms force-pushed the rw-scheduling-policy branch from dcecdfa to 0951d86 Compare January 25, 2022 19:45
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mosabua mosabua removed the request for review from m57lyra January 25, 2022 20:42
@mosabua mosabua removed the WIP label Jan 25, 2022
@rosewms rosewms requested a review from m57lyra January 25, 2022 20:51
Copy link
Copy Markdown
Contributor

@m57lyra m57lyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sopel39 sopel39 merged commit 5646d0a into trinodb:master Jan 26, 2022
@github-actions github-actions bot added this to the 370 milestone Jan 26, 2022
@rosewms rosewms deleted the rw-scheduling-policy branch January 26, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants