Replace cache invalidation with TokenPoll.error#10712
Merged
kokosing merged 1 commit intotrinodb:masterfrom Feb 2, 2022
Merged
Replace cache invalidation with TokenPoll.error#10712kokosing merged 1 commit intotrinodb:masterfrom
kokosing merged 1 commit intotrinodb:masterfrom
Conversation
The issue is with cache.invalidate(key) as described here: trinodb#10512 Instead of doing this, dropToken(key) method will now replace valid Token with proper error, communicating that client has consumed the results of the authentication and they are no longer available. This error will be later cleared by standard after write timeout.
Member
|
is it fixing #10685 ? |
kokosing
approved these changes
Jan 21, 2022
Member
|
Fixes #10685 |
lukasz-walkiewicz
approved these changes
Feb 2, 2022
Member
|
@mosabua No release notes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is with cache.invalidate(key) as described here:
#10512
Instead of doing this, dropToken(key) method will
now replace valid Token with proper error, communicating that
client has consumed the results of the authentication and they are no longer
available. This error will be later cleared by standard after write timeout.