Disable average aggregation pushdown on decimal type in ClickHouse#10703
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Jan 20, 2022
Merged
Disable average aggregation pushdown on decimal type in ClickHouse#10703ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
ebyhr
force-pushed
the
ebi/clickhouse-21.3
branch
from
18cae88 to
37ba751
Compare
hashhar
reviewed
Jan 20, 2022
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
It returns the expected result in 20.8 (31 March 2021 EOL), but it returns the wrong result in new versions.
EOL schedule: 20.3: 31 March 2021 20.8: 31 August 2021
ebyhr
force-pushed
the
ebi/clickhouse-21.3
branch
from
37ba751 to
d94ea35
Compare
wendigo
approved these changes
Jan 20, 2022
hashhar
approved these changes
Jan 20, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM.
I'll investigate/ask upstream if there are functions to emulate Trino behaviour with newer versions. e.g. I see there is a roundBankers but I haven't tried.
Member
Author
|
Already tried |
ebyhr
changed the title
Closed
mosabua
reviewed
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10650
I couldn't find the way to get the same result between new ClickHouse versions and Trino.