Use TupleDomain#intersect for List<TupleDomain> in DynamicFilterService#10700
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Jan 24, 2022
Merged
Use TupleDomain#intersect for List<TupleDomain> in DynamicFilterService#10700sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
findepi
approved these changes
Jan 20, 2022
core/trino-spi/src/main/java/io/trino/spi/predicate/TupleDomain.java
Outdated
Show resolved
Hide resolved
Member
|
@raunaqmorarka please add to TestTupleDomain |
Allowed single element and empty list in TupleDomain#intersect to make it's usage easier. Using the direct API for intersecting lists can be more efficient than intersecting two elements at a time.
raunaqmorarka
force-pushed
the
list-intersect
branch
from
bd90b43 to
858ee76
Compare
Member
Author
added tests in TestTupleDomain |
findepi
approved these changes
Jan 20, 2022
|
|
||
| assertEquals(TupleDomain.intersect(ImmutableList.of()), all()); | ||
| assertEquals(TupleDomain.intersect(ImmutableList.of(tupleDomain1)), tupleDomain1); | ||
| assertEquals(TupleDomain.intersect(ImmutableList.of(tupleDomain1, tupleDomain2)), expectedTupleDomain); |
Member
There was a problem hiding this comment.
yikes, we had no tests here for TupleDomain.intersect(List)... thanks for adding them!
sopel39
approved these changes
Jan 24, 2022
Member
|
This probably does not need RN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow single element list in TupleDomain#intersect to make it's usage easier.
Using the direct API for intersecting lists can be more efficient than
intersecting two elements at a time.