Deny writing unsupported dates in ClickHouse#10672
Conversation
There was a problem hiding this comment.
I think it makes more sense to say "Date must be between ...", since the error is referring to the input value, not the range or reference period. Per Wikipedia:
In chronology and periodization, an epoch or reference epoch is an instant in time chosen as the origin of a particular calendar era. The "epoch" serves as a reference point from which time is measured.
There was a problem hiding this comment.
It would be better to format these as dates, since that is what the user interacts with. How Clickhouse stores dates internally shouldn't matter to the Trino user.
Date must be between 1970-01-01 and 2106-02-07: 1969-12-31
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
Minor comments about the error message, otherwise looks good
ebyhr
force-pushed
the
ebi/clickhouse-deny-unsupported-dates
branch
from
97b1025 to
33b82ee
Compare
The TODO was addressed in PR trinodb#10672.
The TODO was addressed in PR #10672.
2 participants
Fixes #10055