Skip to content

Add authorization check options to iceberg doc#10670

Merged
kokosing merged 1 commit intotrinodb:masterfrom
jhlodin:jl/iceberg-security
Jan 25, 2022
Merged

Add authorization check options to iceberg doc#10670
kokosing merged 1 commit intotrinodb:masterfrom
jhlodin:jl/iceberg-security

Conversation

@jhlodin
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin commented Jan 18, 2022

Issue: #10548

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the 'iceberg.security' property in the catalog properties file by default or does the user need to add it and set the values?

If they have to add it to the file and choose a value, I suggest reframing the sentence to something like:

To enable authorization checks, add the 'iceberg.security' property to the connector catalog properties file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree, but we've used the wording "set/by setting the example.property property in the catalog properties file" just about everywhere else in the connector docs. This property is no different, I'd leave it as-is.

@github-actions github-actions bot added the docs label Jan 19, 2022
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 21, 2022

@kokosing can we get your input here?

@jhlodin
Copy link
Copy Markdown
Contributor Author

jhlodin commented Jan 24, 2022

@kokosing Can you please merge this PR if all looks good? Thanks!

@jhlodin jhlodin force-pushed the jl/iceberg-security branch 2 times, most recently from 7b81518 to de79c03 Compare January 24, 2022 18:41
@kokosing
Copy link
Copy Markdown
Member

Can you please merge this PR if all looks good? Thanks!

Sure. Please ping me once CI gets a green light.

@jhlodin jhlodin force-pushed the jl/iceberg-security branch from de79c03 to cfafa02 Compare January 25, 2022 06:35
@jhlodin jhlodin force-pushed the jl/iceberg-security branch from cfafa02 to 60ae126 Compare January 25, 2022 14:57
@kokosing kokosing merged commit 3cfb1a7 into trinodb:master Jan 25, 2022
@jhlodin jhlodin deleted the jl/iceberg-security branch January 25, 2022 20:10
@github-actions github-actions bot added this to the 370 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants