Replace ImmutableMap.Builder.build() with buildOrThrow()#10648
Merged
findepi merged 2 commits intotrinodb:masterfrom Jan 18, 2022
Merged
Conversation
a019768 to
ab477ab
Compare
Member
Author
|
Interesting. For the first commit, Github reports This explains the the # line change as reported by |
Member
|
red |
losipiuk
approved these changes
Jan 18, 2022
findepi
commented
Jan 18, 2022
Member
Author
There was a problem hiding this comment.
This is a bad change done by structural replace in the IDE.
The Module used here is com.google.inject.Module, not java.lang.Module.
Starting with Guava 31, the `build()` method is discouraged and will be deprecated in upcoming releases. See google/guava@4bbe12c for context. The change itself was done mechanically, with IntelliJ's structural search, then fixed line breaks with regular search for `^(\s+)(.put(All)?\(.*\))(\.buildOrThrow\(\))`, then occurrences of `).buildOrThrow()` fixed manually, then end-of-line searched for in the diff (as they got removed by the structural search/replace) and also restored manually.
ab477ab to
d8efa20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Guava 31, the
build()method is discouraged and will bedeprecated in upcoming releases. See
google/guava@4bbe12c
for context.