Skip to content

Rename parameter for setSchemaAuthorization #10636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electrum merged 1 commit into from
Jan 18, 2022
Merged

Rename parameter for setSchemaAuthorization #10636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/test/java/io/trino/connector/MockConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ public void createSchema(ConnectorSession session, String schemaName, Map<String
public void renameSchema(ConnectorSession session, String source, String target) {}

@Override
public void setSchemaAuthorization(ConnectorSession session, String source, TrinoPrincipal principal) {}
public void setSchemaAuthorization(ConnectorSession session, String schemaName, TrinoPrincipal principal) {}

@Override
public void dropSchema(ConnectorSession session, String schemaName) {}
Expand Down
2 changes: 1 addition & 1 deletion core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ default void renameSchema(ConnectorSession session, String source, String target
/**
* Sets the user/role on the specified schema.
*/
default void setSchemaAuthorization(ConnectorSession session, String source, TrinoPrincipal principal)
default void setSchemaAuthorization(ConnectorSession session, String schemaName, TrinoPrincipal principal)
{
throw new TrinoException(NOT_SUPPORTED, "This connector does not support setting an owner on a schema");
}
Expand Down
4 changes: 2 additions & 2 deletions ...lkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,10 +391,10 @@ public void renameSchema(ConnectorSession session, String source, String target)
}

@Override
public void setSchemaAuthorization(ConnectorSession session, String source, TrinoPrincipal principal)
public void setSchemaAuthorization(ConnectorSession session, String schemaName, TrinoPrincipal principal)
{
try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(classLoader)) {
delegate.setSchemaAuthorization(session, source, principal);
delegate.setSchemaAuthorization(session, schemaName, principal);
}
}

Expand Down
4 changes: 2 additions & 2 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,9 +829,9 @@ public void renameSchema(ConnectorSession session, String source, String target)
}

@Override
public void setSchemaAuthorization(ConnectorSession session, String source, TrinoPrincipal principal)
public void setSchemaAuthorization(ConnectorSession session, String schemaName, TrinoPrincipal principal)
{
metastore.setDatabaseOwner(new HiveIdentity(session), source, HivePrincipal.from(principal));
metastore.setDatabaseOwner(new HiveIdentity(session), schemaName, HivePrincipal.from(principal));
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,9 @@ public void renameSchema(ConnectorSession session, String source, String target)
}

@Override
public void setSchemaAuthorization(ConnectorSession session, String source, TrinoPrincipal principal)
public void setSchemaAuthorization(ConnectorSession session, String schemaName, TrinoPrincipal principal)
{
catalog.setNamespacePrincipal(session, source, principal);
catalog.setNamespacePrincipal(session, schemaName, principal);
}

@Override
Expand Down