Label PRs changing JDBC as such#10634
Merged
findepi merged 1 commit intotrinodb:masterfrom Jan 15, 2022
Merged
Conversation
hashhar
reviewed
Jan 15, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
I didn't check but IIRC jdbc reuses trino-client too (StatementClient?)?
Member
Author
|
Yes, but not every |
Member
Agreed since we are not taking any "action" based on this label for now. |
hashhar
approved these changes
Jan 15, 2022
Member
|
Going forward it might make sense to do label for clients that use the REST API .. so JDBC and CLI and the API itself.. maybe also include web UI. Just a thought.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.