Map ClickHouse IPv4 and IPv6 types to Trino IPADDRESS type#10611
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jan 17, 2022
Merged
Map ClickHouse IPv4 and IPv6 types to Trino IPADDRESS type#10611ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
ebyhr
force-pushed
the
ebi/clickhouse-ipaddress
branch
from
d5a019f to
4c3325a
Compare
hashhar
reviewed
Jan 15, 2022
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseTypeMapping.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/clickhouse-ipaddress
branch
from
4c3325a to
94a9255
Compare
hashhar
approved these changes
Jan 17, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7098