Forbid fields/variables differing in case only#10609
Merged
findepi merged 2 commits intotrinodb:masterfrom Jan 17, 2022
Merged
Conversation
The downside, and biggest change here, is that Hive SerDe variables need to be written as `serde` and not `serDe`. Still, the camel-case of this specific word was applied very inconsistently, so the unification is worth the change.
wendigo
approved these changes
Jan 14, 2022
kokosing
approved these changes
Jan 14, 2022
Member
Author
|
CI #10631 |
findepi
deleted the
findepi/forbid-fields-variables-differing-in-case-only-56262c
branch
This was referenced Jan 17, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downside, and biggest change here, is that Hive SerDe variables need
to be written as
serdeand notserDe. Still, the camel-case of thisspecific word was applied very inconsistently, so the unification is
worth the change.