Skip to content

Error Prone tweaks#10608

Merged
kokosing merged 2 commits intotrinodb:masterfrom
ksobolew:kudi/error-prone-tweaks
Jan 14, 2022
Merged

Error Prone tweaks#10608
kokosing merged 2 commits intotrinodb:masterfrom
ksobolew:kudi/error-prone-tweaks

Conversation

@ksobolew
Copy link
Copy Markdown
Contributor

@ksobolew ksobolew commented Jan 14, 2022

No description provided.

@ksobolew
Remove commented out Error Prone checks
18c9d91 
These were indeed failing in IDEA at some point, but this is no longer
true (either because newer release fixed it, or because this was a
spurious effect).
@ksobolew
Move GuardedBy to an appropriate sorted position
f30067d
@cla-bot cla-bot bot added the cla-signed label Jan 14, 2022
@ksobolew ksobolew requested a review from findepi January 14, 2022 11:14
@kokosing
Copy link
Copy Markdown
Member

kokosing commented Jan 14, 2022

Let me know when CI passes, so I can merge it.

@ksobolew
Copy link
Copy Markdown
Contributor Author

ksobolew commented Jan 14, 2022

ci / error-prone-checks (pull_request) Successful in 21m

There was some weird thing in ci / maven-checks (17) (pull_request), but that's not relevant.

@kokosing
Copy link
Copy Markdown
Member

kokosing commented Jan 14, 2022

Please report a flaky test issue.

@kokosing kokosing merged commit d2c2e39 into trinodb:master Jan 14, 2022
@kokosing
Copy link
Copy Markdown
Member

kokosing commented Jan 14, 2022

Thanks!

@ksobolew ksobolew deleted the kudi/error-prone-tweaks branch January 14, 2022 15:21
@ksobolew
Copy link
Copy Markdown
Contributor Author

ksobolew commented Jan 14, 2022

Please report a flaky test issue.

I think this was a glitch in the environment, does this qualify as a flaky test?

🐢 Validating trino:369-SNAPSHOT-amd64 on platform linux/amd64...
🚨 Too many retries waiting for Trino to start
Error response from daemon: No such container: 59f4b62fecaee5268410428097f0a231593223e060419324898fe438c4796750
Error response from daemon: No such container: 59f4b62fecaee5268410428097f0a231593223e060419324898fe438c4796750
Error: Process completed with exit code 1.

@kokosing
Copy link
Copy Markdown
Member

kokosing commented Jan 14, 2022

Anything that randomly happens and makes the build red should be reported IMO

@github-actions github-actions bot added this to the 369 milestone Jan 14, 2022
@mosabua mosabua mentioned this pull request Jan 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepi findepi findepi approved these changes

@kokosing kokosing kokosing approved these changes

Assignees

No one assigned

Labels

cla-signed

Milestone

369

Development

Successfully merging this pull request may close these issues.

3 participants

@ksobolew @kokosing @findepi