Remove Block writePositionTo and BlockBuilder appendStructure#10602
Merged
dain merged 1 commit intotrinodb:masterfrom Feb 2, 2022
Merged
Remove Block writePositionTo and BlockBuilder appendStructure#10602dain merged 1 commit intotrinodb:masterfrom
dain merged 1 commit intotrinodb:masterfrom
Conversation
electrum
approved these changes
Jan 26, 2022
These methods are use almost exclusively by tests and have a huge footprint in our SPI. Additionally, the methods are dangerous to use because they do not interact with Types. The methods are replaced with the existing Type appendTo or writeObject methods.
dain
force-pushed
the
remove-block-append-position
branch
from
34c4261 to
e696cb1
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These methods are used almost exclusively by tests and have a huge footprint in our SPI. Additionally, the methods are dangerous to use because they do not interact with Types. The methods are replaced with the existing Type appendTo or writeObject methods.
Documentation
Release notes
SPI
BlockwritePositionToandBlockBuilderappendStructuremethods. Use of these methods can be replaced with the existingTypeappendToorwriteObjectmethods. ({issue}10602)