Skip to content

Add map_string_as_varchar session property in ClickHouse#10601

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/clickhouse-map-string-as-varchar-session-properties
Jan 14, 2022
Merged

Add map_string_as_varchar session property in ClickHouse#10601
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/clickhouse-map-string-as-varchar-session-properties

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jan 14, 2022

Relates to #7102

Docs will be handled in #7099

@cla-bot cla-bot bot added the cla-signed label Jan 14, 2022
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Jan 14, 2022

CI hit #10363

@ebyhr ebyhr requested review from findepi and hashhar January 14, 2022 04:28
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have a test when we insert without mapStringAsVarcharSession and read with it, and vice versa?

@ebyhr ebyhr force-pushed the ebi/clickhouse-map-string-as-varchar-session-properties branch from 5a0c630 to 4e41546 Compare January 14, 2022 09:54
@ebyhr ebyhr merged commit 1f3653a into trinodb:master Jan 14, 2022
@ebyhr ebyhr deleted the ebi/clickhouse-map-string-as-varchar-session-properties branch January 14, 2022 12:26
@ebyhr ebyhr mentioned this pull request Jan 14, 2022
@hashhar
Copy link
Copy Markdown
Member

hashhar commented Jan 14, 2022

Question : Could the same effect be achieved via jdbc-types-mapped-to-varchar?

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Jan 14, 2022

Yes if users specify the name including the length.

  • map-string-as-varchar map all FixedString to varchar regardless of the length.
  • jdbc-types-mapped-to-varchar expects the entire type name. e.g. FixedString(5)

@github-actions github-actions bot added this to the 369 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants