Remove fine-grained spill toggles#10591
Merged
findepi merged 2 commits intotrinodb:masterfrom Jan 14, 2022
Merged
Conversation
findepi
force-pushed
the
findepi/spill-regardless
branch
from
ba7319e to
84de230
Compare
The toggles to control whether order by or window operators can spill were added as kill switches when the spill was implemented for these operators, while spill for join was available for some time already and potentially adopted. The toggles are not needed anymore.
findepi
force-pushed
the
findepi/spill-regardless
branch
from
84de230 to
f20c361
Compare
martint
approved these changes
Jan 14, 2022
This was referenced Jan 15, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toggles to control whether order by or window operators can spill
were added as kill switches when the spill was implemented for these
operators, while spill for join was available for some time already and
potentially adopted. The toggles are not needed anymore.