Rename table layout classes, remove 'New'#10587
Merged
findepi merged 1 commit intotrinodb:masterfrom Feb 1, 2022
Merged
Conversation
Member
Author
Member
Author
|
CI #9415 |
martint
approved these changes
Jan 14, 2022
Praveen2112
approved these changes
Jan 20, 2022
The classes `NewTableLayout` and `ConnectorNewTableLayout` had 'New' in their names to differentiate from the old table layout-related classes. Now, that the old table layout functionality is removed, the rationale is no longer valid, and names need to be cleaned. It's a breaking change, but necessary to avoid having something for legacy reasons only, for ever. Furthermore, the previous name like `ConnectorNewTableLayout` could be understood as "layout for new tables", which is misleading, as the class is used for new tables, for writes and execute too.
findepi
force-pushed
the
findepi/old-table-layout
branch
from
1bab8fa to
e89dc24
Compare
Member
Author
|
(rebased) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classes
NewTableLayoutandConnectorNewTableLayouthad 'New' intheir names to differentiate from the old table layout-related classes.
Now, that the old table layout functionality is removed, the rationale
is no longer valid, and names need to be cleaned. It's a breaking
change, but necessary to avoid having something for legacy reasons only,
for ever.
Furthermore, the previous name like
ConnectorNewTableLayoutcould beunderstood as "layout for new tables", which is misleading, as the class
is used for new tables, for writes and execute too.