Remove distinction between system and user memory

[findepi]

No description provided.

[findepi]

cc @erichwang

[losipiuk]

❤️

[losipiuk]

trino/core/trino-main/src/main/java/io/trino/memory/MemoryManagerConfig.java

Lines 38 to 41 in cea5842

	// enforced against user memory allocations
	private DataSize maxQueryMemory = DataSize.of(20, GIGABYTE);
	// enforced against user + system memory allocations (default is maxQueryMemory * 2)
	private DataSize maxQueryTotalMemory;

remainder?

[losipiuk]

https://github.com/trinodb/trino/blob/40046c0661056c15571e03be0bfaac163d0ade79/plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcDeletedRows.java#L68

raname

[losipiuk]

QueryStats still has user/total distincition. On purpose?

[findepi]

trino/core/trino-main/src/main/java/io/trino/memory/MemoryManagerConfig.java

Lines 38 to 41 in cea5842

	// enforced against user memory allocations
	private DataSize maxQueryMemory = DataSize.of(20, GIGABYTE);
	// enforced against user + system memory allocations (default is maxQueryMemory * 2)
	private DataSize maxQueryTotalMemory;

remainder?

No. The from cluster memory manager perspective, total memory = user + revocable.
I've updated the docs to make it clear.

QueryStats still has user/total distincition. On purpose?

same

[losipiuk]

preexistent - can you still rename this to maxQueryMaxMemoryPerTask

[findepi]

you mean to swap "query" and "max"? let's follow up

[findepi]

(squashed)

[findepi]

CI #10631, was green before squash.
rerunning.

[findepi]

(rebased)

[ElapsedSoul]

Old configurations are:

max-total-memory-per-node=40GB
max-memory-per-node=32GB

which value should max-memory-per-node now be?
32 or 40?