Conversation
|
Tested on my fork -- findepi#1 . |
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Thanks.
A question whether this works as expected.
.github/config/labeler-config.yml
Outdated
There was a problem hiding this comment.
Note that labels get added "after" the PR gets created and hence the CI run won't see the labels most probably - can we test this? (subsequent pushes would see the labels though).
There was a problem hiding this comment.
Yes, this is what i expect. This automation doesn't free us from thinking.
However, oftentimes PRs do involve multiple pushes, so this may free us from doing the thing manually.
There was a problem hiding this comment.
There's still one issue I see - a reviewer won't know whether the hive tests actually ran just by looking at presence of label.
I'm fine with merging this provided people know of the behaviour to expect from the label.
There was a problem hiding this comment.
Not sure if it is already discussed, what if we use workflow_run so that we could run this workflow could add labels and ci could use them ?
There was a problem hiding this comment.
There's still one issue I see - a reviewer won't know whether the hive tests actually ran just by looking at presence of label.
If you see a label added after the PR is created, you must not assume it was observed by the workflow run.
But, if there was a push since label was added, then you can assume it's observed
The labeler workflow is courtesy of Ashhar. Co-authored-by: Ashhar Hasan <ashhar.hasan@starburstdata.com>
findepi
force-pushed
the
findepi/add-tests-hive-automatically-a8d83a
branch
from
9f3306f to
2cae5c9
Compare
4 participants
The labeler workflow is courtesy of Ashhar.
Co-authored-by: Ashhar Hasan ashhar.hasan@starburstdata.com