[TMP] Run MemSQL tests for https://github.com/trinodb/trino/pull/8939

docs/src/main/sphinx/connector/alter-schema-limitation.fragment

@@ -0,0 +1,5 @@
+ALTER SCHEMA
+^^^^^^^^^^^^
+
+The connector supports renaming a schema with the ``ALTER SCHEMA RENAME``
+statement. ``ALTER SCHEMA SET AUTHORIZATION`` is not supported.

docs/src/main/sphinx/connector/postgresql.rst

@@ -146,6 +146,8 @@ statements, the connector supports the following features:
 
 .. include:: alter-table-limitation.fragment
 
+.. include:: alter-schema-limitation.fragment
+
 .. _postgresql-pushdown:
 
 Pushdown

docs/src/main/sphinx/connector/redshift.rst

@@ -98,11 +98,10 @@ statements, the connector supports the following features:
 * :doc:`/sql/insert`
 * :doc:`/sql/delete`
 * :doc:`/sql/truncate`
-* :doc:`/sql/create-table`
-* :doc:`/sql/create-table-as`
-* :doc:`/sql/drop-table`
-* :doc:`/sql/create-schema`
-* :doc:`/sql/drop-schema`
-* :doc:`/sql/comment`
+* :ref:`sql-schema-table-management`
 
 .. include:: sql-delete-limitation.fragment
+
+.. include:: alter-table-limitation.fragment
+
+.. include:: alter-schema-limitation.fragment

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java

@@ -828,6 +828,25 @@ protected String dropSchemaSql(String schemaName)
         return "DROP SCHEMA " + quoted(schemaName);
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        ConnectorIdentity identity = session.getIdentity();
+        try (Connection connection = connectionFactory.openConnection(session)) {
+            String remoteSchemaName = identifierMapping.toRemoteSchemaName(identity, connection, schemaName);
+            String newRemoteSchemaName = identifierMapping.toRemoteSchemaName(identity, connection, newSchemaName);
+            execute(connection, renameSchemaSql(remoteSchemaName, newRemoteSchemaName));
+        }
+        catch (SQLException e) {
+            throw new TrinoException(JDBC_ERROR, e);
+        }
+    }
+
+    protected String renameSchemaSql(String remoteSchemaName, String newRemoteSchemaName)
+    {
+        return "ALTER SCHEMA " + quoted(remoteSchemaName) + " RENAME TO " + quoted(newRemoteSchemaName);
+    }
+
     protected void execute(ConnectorSession session, String query)
     {
         try (Connection connection = connectionFactory.openConnection(session)) {

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/CachingJdbcClient.java

@@ -365,6 +365,13 @@ public void dropSchema(ConnectorSession session, String schemaName)
         invalidateSchemasCache();
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        delegate.renameSchema(session, schemaName, newSchemaName);
+        invalidateSchemasCache();
+    }
+
     @Override
     public void setColumnComment(ConnectorSession session, JdbcTableHandle handle, JdbcColumnHandle column, Optional<String> comment)
     {

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java

@@ -790,4 +790,10 @@ public void dropSchema(ConnectorSession session, String schemaName)
     {
         jdbcClient.dropSchema(session, schemaName);
     }
+
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        jdbcClient.renameSchema(session, schemaName, newSchemaName);
+    }
 }

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/ForwardingJdbcClient.java

@@ -311,6 +311,12 @@ public void dropSchema(ConnectorSession session, String schemaName)
         delegate().dropSchema(session, schemaName);
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        delegate().renameSchema(session, schemaName, newSchemaName);
+    }
+
     @Override
     public Optional<SystemTable> getSystemTable(ConnectorSession session, SchemaTableName tableName)
     {

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcClient.java

@@ -163,6 +163,8 @@ PreparedStatement getPreparedStatement(Connection connection, String sql)
 
     void dropSchema(ConnectorSession session, String schemaName);
 
+    void renameSchema(ConnectorSession session, String schemaName, String newSchemaName);
+
     default Optional<SystemTable> getSystemTable(ConnectorSession session, SchemaTableName tableName)
     {
         return Optional.empty();

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/jmx/JdbcClientStats.java

@@ -32,6 +32,7 @@ public final class JdbcClientStats
     private final JdbcApiStats setColumnComment = new JdbcApiStats();
     private final JdbcApiStats dropColumn = new JdbcApiStats();
     private final JdbcApiStats dropSchema = new JdbcApiStats();
+    private final JdbcApiStats renameSchema = new JdbcApiStats();
     private final JdbcApiStats dropTable = new JdbcApiStats();
     private final JdbcApiStats finishInsertTable = new JdbcApiStats();
     private final JdbcApiStats getColumns = new JdbcApiStats();
@@ -154,6 +155,13 @@ public JdbcApiStats getDropSchema()
         return dropSchema;
     }
 
+    @Managed
+    @Nested
+    public JdbcApiStats getRenameSchema()
+    {
+        return renameSchema;
+    }
+
     @Managed
     @Nested
     public JdbcApiStats getDropTable()

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/jmx/StatisticsAwareJdbcClient.java

@@ -330,6 +330,12 @@ public void dropSchema(ConnectorSession session, String schemaName)
         stats.getDropSchema().wrap(() -> delegate().dropSchema(session, schemaName));
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        stats.getRenameSchema().wrap(() -> delegate().renameSchema(session, schemaName, newSchemaName));
+    }
+
     @Override
     public Optional<SystemTable> getSystemTable(ConnectorSession session, SchemaTableName tableName)
     {

plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestJdbcCachingConnectorSmokeTest.java

@@ -131,7 +131,6 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
     {
         switch (connectorBehavior) {
             case SUPPORTS_RENAME_TABLE_ACROSS_SCHEMAS:
-            case SUPPORTS_RENAME_SCHEMA:
                 return false;
 
             default:

plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestJdbcConnectorTest.java

@@ -58,7 +58,6 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
                 return false;
 
             case SUPPORTS_RENAME_TABLE_ACROSS_SCHEMAS:
-            case SUPPORTS_RENAME_SCHEMA:
                 return false;
 
             case SUPPORTS_COMMENT_ON_TABLE:

plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java

@@ -266,6 +266,13 @@ public void dropSchema(ConnectorSession session, String schemaName)
         execute(session, "DROP DATABASE " + quoted(schemaName));
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        // TODO: https://github.com/trinodb/trino/issues/10558
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     @Override
     public void addColumn(ConnectorSession session, JdbcTableHandle handle, ColumnMetadata column)
     {

plugin/trino-druid/src/main/java/io/trino/plugin/druid/DruidJdbcClient.java

@@ -400,6 +400,12 @@ public void dropSchema(ConnectorSession session, String schemaName)
         throw new TrinoException(NOT_SUPPORTED, "This connector does not support dropping schemas");
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     private WriteMapping legacyToWriteMapping(Type type)
     {
         // TODO (https://github.com/trinodb/trino/issues/497) Implement proper type mapping and add test

plugin/trino-memsql/src/main/java/io/trino/plugin/memsql/MemSqlClient.java

@@ -422,6 +422,12 @@ public void renameColumn(ConnectorSession session, JdbcTableHandle handle, JdbcC
         }
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     @Override
     protected String getTableSchemaName(ResultSet resultSet)
             throws SQLException

plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java

@@ -515,6 +515,12 @@ public void renameColumn(ConnectorSession session, JdbcTableHandle handle, JdbcC
         }
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     @Override
     protected void copyTableSchema(Connection connection, String catalogName, String schemaName, String tableName, String newTableName, List<String> columnNames)
     {

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java

@@ -244,6 +244,12 @@ public void dropSchema(ConnectorSession session, String schemaName)
         throw new TrinoException(NOT_SUPPORTED, "This connector does not support dropping schemas");
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     @Override
     public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connection connection, JdbcTypeHandle typeHandle)
     {

plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixClient.java

@@ -621,6 +621,12 @@ protected void renameTable(ConnectorSession session, String catalogName, String
         throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming tables");
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     @Override
     public Map<String, Object> getTableProperties(ConnectorSession session, JdbcTableHandle handle)
     {

plugin/trino-phoenix5/src/main/java/io/trino/plugin/phoenix5/PhoenixClient.java

@@ -613,6 +613,12 @@ protected void renameTable(ConnectorSession session, String catalogName, String
         throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming tables");
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     @Override
     public Map<String, Object> getTableProperties(ConnectorSession session, JdbcTableHandle handle)
     {

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java

@@ -116,9 +116,6 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
             case SUPPORTS_RENAME_TABLE_ACROSS_SCHEMAS:
                 return false;
 
-            case SUPPORTS_RENAME_SCHEMA:
-                return false;
-
             case SUPPORTS_CANCELLATION:
                 return true;
 

plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerClient.java

@@ -241,6 +241,12 @@ public void renameColumn(ConnectorSession session, JdbcTableHandle handle, JdbcC
         execute(session, sql);
     }
 
+    @Override
+    public void renameSchema(ConnectorSession session, String schemaName, String newSchemaName)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support renaming schemas");
+    }
+
     @Override
     protected void copyTableSchema(Connection connection, String catalogName, String schemaName, String tableName, String newTableName, List<String> columnNames)
     {

testing/trino-testing/src/main/java/io/trino/testing/TestingConnectorBehavior.java

@@ -46,7 +46,8 @@ public enum TestingConnectorBehavior
     SUPPORTS_JOIN_PUSHDOWN_WITH_VARCHAR_EQUALITY(fallback -> fallback.test(SUPPORTS_JOIN_PUSHDOWN) && fallback.test(SUPPORTS_PREDICATE_PUSHDOWN_WITH_VARCHAR_EQUALITY)),
     SUPPORTS_JOIN_PUSHDOWN_WITH_VARCHAR_INEQUALITY(fallback -> fallback.test(SUPPORTS_JOIN_PUSHDOWN) && fallback.test(SUPPORTS_PREDICATE_PUSHDOWN_WITH_VARCHAR_INEQUALITY)),
     SUPPORTS_CREATE_SCHEMA,
-    SUPPORTS_RENAME_SCHEMA,
+    // Expect rename to be supported when create schema is supported, to help make connector implementations coherent.
+    SUPPORTS_RENAME_SCHEMA(SUPPORTS_CREATE_SCHEMA),
 
     SUPPORTS_CREATE_TABLE,
     SUPPORTS_CREATE_TABLE_WITH_DATA(SUPPORTS_CREATE_TABLE),