Skip to content

Set keep_alive_timeout as 10 seconds in ClickHouse testing server#10542

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/clickhouse-keep_alive_timeout
Jan 12, 2022
Merged

Set keep_alive_timeout as 10 seconds in ClickHouse testing server#10542
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/clickhouse-keep_alive_timeout

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jan 11, 2022

Fixes #9300

300 stress tests succeeded.

@cla-bot cla-bot bot added the cla-signed label Jan 11, 2022
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? add code comment here & in cmt message too.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose is fixing flaky server as ClickHouse/clickhouse-java#717.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there /etc/clickhouse-server/config.d/config.xml in the image?
or we're creating a new file? then, can we give it a more specific name?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new file. I renamed to custom.yml.

For avoiding below failure during copy of TPCH tables.
 ClickHouse exception, code: 1002, host: localhost, port: <port>;
 localhost:<port> failed to respond
@ebyhr ebyhr force-pushed the ebi/clickhouse-keep_alive_timeout branch from f958e26 to 7e7c2c7 Compare January 11, 2022 23:52
@ebyhr ebyhr marked this pull request as ready for review January 12, 2022 01:13
@ebyhr ebyhr added the maintenance Project maintenance task label Jan 12, 2022
@ebyhr ebyhr merged commit effc4a4 into trinodb:master Jan 12, 2022
@ebyhr ebyhr deleted the ebi/clickhouse-keep_alive_timeout branch January 12, 2022 03:49
@github-actions github-actions bot added this to the 369 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed maintenance Project maintenance task

Development

Successfully merging this pull request may close these issues.

Flaky test setup TestClickHouseConnectorTest.init

2 participants