Use LocalDate and LocalDateTime on ClickHouse type mapping#10530
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Jan 11, 2022
Merged
Use LocalDate and LocalDateTime on ClickHouse type mapping#10530ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
Additionally, add some date cases to type mapping test.
ebyhr
force-pushed
the
ebi/clickhouse-date
branch
from
c740f76 to
3e5f998
Compare
ebyhr
force-pushed
the
ebi/clickhouse-date
branch
from
3e5f998 to
aa8c5ec
Compare
hashhar
approved these changes
Jan 11, 2022
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseTypeMapping.java
Outdated
Show resolved
Hide resolved
Additionally, change the reolution to seconds from millis as millis is unsupporeted in ClickHouse.
ebyhr
force-pushed
the
ebi/clickhouse-date
branch
from
aa8c5ec to
c929d3e
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.