Skip to content

Speed up builds of freshly checked out branches #10519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nineinchnick wants to merge 2 commits into from
Closed

Speed up builds of freshly checked out branches #10519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5978e
Don't force check plugins to be always enabled
Jan 11, 2022
141ef0c
Add a profile to quickly build freshly checked out branches
Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions core/trino-main/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,20 @@
</dependencies>

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<configuration>
<ignoreClassNamePatterns>
<!-- we require certain org.testng.Assert methods be called via our Assert class, so that class needs to be allowed to call them -->
<ignoreClassNamePattern>io/trino/testing/assertions/Assert</ignoreClassNamePattern>
</ignoreClassNamePatterns>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand All @@ -480,17 +494,6 @@
</dependency>
</dependencies>
</plugin>

<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<configuration>
<ignoreClassNamePatterns>
<!-- we require certain org.testng.Assert methods be called via our Assert class, so that class needs to be allowed to call them -->
<ignoreClassNamePattern>io/trino/testing/assertions/Assert</ignoreClassNamePattern>
</ignoreClassNamePatterns>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
54 changes: 27 additions & 27 deletions core/trino-server-rpm/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,33 @@
</mapping>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>default</id>
<phase>verify</phase>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
<configuration>
<!-- All Trino modules are imported into this module as "provided" dependencies what makes dependencies from all the modules to be cross checked for compatibility -->
<!-- Override rules to disable dependency checks as dependencies of different connectors don't have to be compatible -->
<rules combine.self="override">
<requireFilesSize>
<!-- Maven Central has a 1GB limit -->
<maxsize>1106000000</maxsize>
<files>
<file>${project.build.directory}/${project.build.finalName}.noarch.rpm</file>
</files>
</requireFilesSize>
</rules>
<fail>true</fail>
</configuration>
</plugin>
</plugins>
</pluginManagement>

Expand Down Expand Up @@ -274,33 +301,6 @@
</packages>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>default</id>
<phase>verify</phase>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
<configuration>
<!-- All Trino modules are imported into this module as "provided" dependencies what makes dependencies from all the modules to be cross checked for compatibility -->
<!-- Override rules to disable dependency checks as dependencies of different connectors don't have to be compatible -->
<rules combine.self="override">
<requireFilesSize>
<!-- Maven Central has a 1GB limit -->
<maxsize>1106000000</maxsize>
<files>
<file>${project.build.directory}/${project.build.finalName}.noarch.rpm</file>
</files>
</requireFilesSize>
</rules>
<fail>true</fail>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
52 changes: 27 additions & 25 deletions core/trino-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,30 +27,32 @@
</properties>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<configuration>
<rules combine.self="override">
<requireFilesSize>
<!-- Maven Central has a 1GB limit -->
<maxsize>1073741824</maxsize>
<files>
<file>${project.build.directory}/${project.artifactId}-${project.version}.tar.gz</file>
</files>
</requireFilesSize>
</rules>
</configuration>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<configuration>
<rules combine.self="override">
<requireFilesSize>
<!-- Maven Central has a 1GB limit -->
<maxsize>1073741824</maxsize>
<files>
<file>${project.build.directory}/${project.artifactId}-${project.version}.tar.gz</file>
</files>
</requireFilesSize>
</rules>
</configuration>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
58 changes: 30 additions & 28 deletions plugin/trino-accumulo/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,33 +320,35 @@
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>copy-iterators</id>
<!-- the resource is not needed for compilation -->
<phase>process-test-classes</phase>
<goals>
<goal>copy</goal>
</goals>
<configuration>
<skip>false</skip>
<artifactItems>
<artifactItem>
<groupId>io.trino</groupId>
<artifactId>trino-accumulo-iterators</artifactId>
<version>${project.version}</version>
<type>jar</type>
</artifactItem>
</artifactItems>
<stripVersion>true</stripVersion>
<outputDirectory>${project.build.testOutputDirectory}</outputDirectory>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>copy-iterators</id>
<!-- the resource is not needed for compilation -->
<phase>process-test-classes</phase>
<goals>
<goal>copy</goal>
</goals>
<configuration>
<skip>false</skip>
<artifactItems>
<artifactItem>
<groupId>io.trino</groupId>
<artifactId>trino-accumulo-iterators</artifactId>
<version>${project.version}</version>
<type>jar</type>
</artifactItem>
</artifactItems>
<stripVersion>true</stripVersion>
<outputDirectory>${project.build.testOutputDirectory}</outputDirectory>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
58 changes: 30 additions & 28 deletions plugin/trino-cassandra/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,33 +203,35 @@
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.basepom.maven</groupId>
<artifactId>duplicate-finder-maven-plugin</artifactId>
<configuration>
<ignoredDependencies>
<dependency>
<groupId>org.cassandraunit</groupId>
<artifactId>cassandra-unit</artifactId>
</dependency>
</ignoredDependencies>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<configuration>
<rules>
<requireUpperBoundDeps>
<excludes combine.children="append">
<exclude>org.yaml:snakeyaml</exclude>
</excludes>
</requireUpperBoundDeps>
</rules>
</configuration>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.basepom.maven</groupId>
<artifactId>duplicate-finder-maven-plugin</artifactId>
<configuration>
<ignoredDependencies>
<dependency>
<groupId>org.cassandraunit</groupId>
<artifactId>cassandra-unit</artifactId>
</dependency>
</ignoredDependencies>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<configuration>
<rules>
<requireUpperBoundDeps>
<excludes combine.children="append">
<exclude>org.yaml:snakeyaml</exclude>
</excludes>
</requireUpperBoundDeps>
</rules>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
26 changes: 14 additions & 12 deletions plugin/trino-password-authenticators/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,19 @@
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<configuration>
<ignoreClassNamePatterns>
<!-- To allow usage of java.util.Hashtable -->
<ignoreClassNamePattern>io/trino/plugin/password/jndi/JndiUtils</ignoreClassNamePattern>
</ignoreClassNamePatterns>
</configuration>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<configuration>
<ignoreClassNamePatterns>
<!-- To allow usage of java.util.Hashtable -->
<ignoreClassNamePattern>io/trino/plugin/password/jndi/JndiUtils</ignoreClassNamePattern>
</ignoreClassNamePatterns>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
46 changes: 24 additions & 22 deletions plugin/trino-phoenix/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,27 +313,29 @@
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.basepom.maven</groupId>
<artifactId>duplicate-finder-maven-plugin</artifactId>
<configuration>
<ignoredResourcePatterns>
<ignoredResourcePattern>mrapp-generated-classpath</ignoredResourcePattern>
<ignoredResourcePattern>about.html</ignoredResourcePattern>
<!-- org.apache.commons:commons-math3 french localization file duplicate-->
<ignoredResourcePattern>assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties</ignoredResourcePattern>
<!-- io.airlift:joni and phoenix-client's org.jruby.joni:joni resource duplicates-->
<ignoredResourcePattern>tables/.*\.bin</ignoredResourcePattern>
</ignoredResourcePatterns>
<ignoredDependencies>
<dependency>
<groupId>com.clearspring.analytics</groupId>
<artifactId>stream</artifactId>
</dependency>
</ignoredDependencies>
</configuration>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.basepom.maven</groupId>
<artifactId>duplicate-finder-maven-plugin</artifactId>
<configuration>
<ignoredResourcePatterns>
<ignoredResourcePattern>mrapp-generated-classpath</ignoredResourcePattern>
<ignoredResourcePattern>about.html</ignoredResourcePattern>
<!-- org.apache.commons:commons-math3 french localization file duplicate-->
<ignoredResourcePattern>assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties</ignoredResourcePattern>
<!-- io.airlift:joni and phoenix-client's org.jruby.joni:joni resource duplicates-->
<ignoredResourcePattern>tables/.*\.bin</ignoredResourcePattern>
</ignoredResourcePatterns>
<ignoredDependencies>
<dependency>
<groupId>com.clearspring.analytics</groupId>
<artifactId>stream</artifactId>
</dependency>
</ignoredDependencies>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
Loading