Improve null statistics handling in product tests#10516
Merged
findepi merged 2 commits intotrinodb:masterfrom Jan 13, 2022
Merged
Improve null statistics handling in product tests#10516findepi merged 2 commits intotrinodb:masterfrom
findepi merged 2 commits intotrinodb:masterfrom
Conversation
findepi
approved these changes
Jan 10, 2022
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/StatisticsFetcher.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/StatisticsFetcher.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/StatisticsFetcher.java
Outdated
Show resolved
Hide resolved
This statistics is not really useful and most of the time Docker engine returns null for it
wendigo
force-pushed
the
serafin/improve-null-handling-in-pt
branch
from
fabb8f1 to
af206cd
Compare
findepi
approved these changes
Jan 10, 2022
Contributor
Author
|
@findepi can we merge that? |
Member
|
it's red. What's the problem? |
Contributor
Author
|
Some unrelated flakyness of phoenix tests:
|
Member
|
Do we have an issue for this? |
Contributor
Author
I'll create one @findepi |
Member
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10366