Skip to content

Clarify how decimal duration values are handled#10492

Merged
martint merged 1 commit intotrinodb:masterfrom
jhlodin:jl/decimal-duration-fix
Jan 10, 2022
Merged

Clarify how decimal duration values are handled#10492
martint merged 1 commit intotrinodb:masterfrom
jhlodin:jl/decimal-duration-fix

Conversation

@jhlodin
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin commented Jan 6, 2022

See resolution of #10356

@cla-bot cla-bot bot added the cla-signed label Jan 6, 2022
@jhlodin jhlodin added the docs label Jan 6, 2022
m57lyra
m57lyra approved these changes Jan 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@m57lyra m57lyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosabua mosabua removed the request for review from rosewms January 10, 2022 20:30
@martint martint merged commit 7ed5bda into trinodb:master Jan 10, 2022
@jhlodin jhlodin deleted the jl/decimal-duration-fix branch January 10, 2022 22:17
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 10, 2022

Thanks for the merge @martint !

@github-actions github-actions bot added this to the 368 milestone Jan 11, 2022
@mosabua mosabua mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosabua mosabua mosabua approved these changes

@martint martint Awaiting requested review from martint

@hashhar hashhar Awaiting requested review from hashhar

+1 more reviewer

@m57lyra m57lyra m57lyra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed docs

Milestone

368

Development

Successfully merging this pull request may close these issues.

4 participants

@jhlodin @mosabua @m57lyra @martint