Skip to content

Revert "Test for Hive compatibility across file formats"#10488

Merged
hashhar merged 1 commit intomasterfrom
revert-10309-findinpath/product-tests-hive-compatibility
Jan 6, 2022
Merged

Revert "Test for Hive compatibility across file formats"#10488
hashhar merged 1 commit intomasterfrom
revert-10309-findinpath/product-tests-hive-compatibility

Conversation

@hashhar
Copy link
Copy Markdown
Member

@hashhar hashhar commented Jan 6, 2022

Reverts #10309

The branch was stale at the time of merge and TestHiveStorageFormats.testInsertAllSupportedDataTypesWithTrino in suite-2 with args [StorageFormat{name=PARQUET, properties={}, sessionProperties={hive.experimental_parquet_optimized_writer_enabled=true}}] (Groups: storage_formats_detailed) has been failing consistently since.

This reverts commit 3fd1a9b.

The pull-request was stale at the time of merge and
TestHiveStorageFormats.testInsertAllSupportedDataTypesWithTrino in
suite-2 with args [StorageFormat{name=PARQUET, properties={},
sessionProperties={hive.experimental_parquet_optimized_writer_enabled=true}}]
(Groups: storage_formats_detailed) has been failing consistently since.
@hashhar hashhar force-pushed the revert-10309-findinpath/product-tests-hive-compatibility branch from f38f778 to 9d97b48 Compare January 6, 2022 10:29
@hashhar
Copy link
Copy Markdown
Member Author

hashhar commented Jan 6, 2022

Unrelated failure - io.trino.memory.TestMemoryManager.testClusterPools (doesn't fail locally - seems flaky)

io.trino.memory.TestMemoryManager.testClusterPools  Time elapsed: 6.585 s  <<< FAILURE!
java.lang.AssertionError: expected [966332770] but found [966367642]
	at org.testng.Assert.fail(Assert.java:94)
	at org.testng.Assert.failNotEquals(Assert.java:513)
	at org.testng.Assert.assertEqualsImpl(Assert.java:135)
	at org.testng.Assert.assertEquals(Assert.java:116)
	at org.testng.Assert.assertEquals(Assert.java:284)
	at org.testng.Assert.assertEquals(Assert.java:294)
	at io.trino.memory.TestMemoryManager.testClusterPools(TestMemoryManager.java:320)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
	at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

@hashhar hashhar merged commit 1f98270 into master Jan 6, 2022
@hashhar hashhar deleted the revert-10309-findinpath/product-tests-hive-compatibility branch January 6, 2022 12:01
@github-actions github-actions bot added this to the 368 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants