Ignore REMOTE_TASK_FAILED errors in DeduplicationExchangeClientBuffer#10481
Merged
martint merged 5 commits intotrinodb:masterfrom Jan 6, 2022
Merged
Ignore REMOTE_TASK_FAILED errors in DeduplicationExchangeClientBuffer#10481martint merged 5 commits intotrinodb:masterfrom
martint merged 5 commits intotrinodb:masterfrom
Conversation
Contributor
Author
|
Resolves #10395 |
martint
reviewed
Jan 6, 2022
core/trino-main/src/main/java/io/trino/operator/StreamingExchangeClientBuffer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/DeduplicationExchangeClientBuffer.java
Outdated
Show resolved
Hide resolved
While the exception is never serialized and the error code object is a singleton within a node it is still safer to check for equallity using the equals method
REMOTE_TASK_FAILED errors are intended to be reported and handled as part of a status update for a task to correctly report original error
arhimondr
force-pushed
the
fix-incorrect-error
branch
from
a0cf480 to
84e63c7
Compare
Contributor
Author
|
@martint updated |
martint
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REMOTE_TASK_FAILED errors are intended to be reported and handled as
part of a status update for a task to correctly report original error