Report connector provided read time as connector metric#10472
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Jan 11, 2022
Merged
Report connector provided read time as connector metric#10472sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
fyi @martint |
findepi
reviewed
Jan 5, 2022
core/trino-main/src/main/java/io/trino/operator/OperatorContext.java
Outdated
Show resolved
Hide resolved
martint
reviewed
Jan 6, 2022
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/metrics/DurationTiming.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 11, 2022
lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/metrics/TestMetrics.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 11, 2022
Member
There was a problem hiding this comment.
I am not a big fan of using 0 as a special marker. Can we use OptionalLong. Or if maybe -1 so we use value which is out of domain for valid values?
Member
Author
There was a problem hiding this comment.
I will leave it as is. It's not a maker really, but rather skipping meaningless stat.
We do something similar for other things, e.g:
39f48d5
if (node.isMaySkipOutputDuplicates()) {
nodeOutput.appendDetailsLine("maySkipOutputDuplicates = %s", node.isMaySkipOutputDuplicates());
}
If I used -1 then I would have to take care of it while doing addition (synchronization). Similaraly Optional would require some synchronization and locking.
losipiuk
approved these changes
Jan 11, 2022
Previously connector provided read time was added to OperatorContext#addInputTiming which caused table scan wall time to be accounted for twice.
sopel39
force-pushed
the
ks/physical_read_time
branch
from
4792b03 to
b4d12e4
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously connector provided read time was added
to OperatorContext#addInputTiming which caused table scan
wall time to be accounted for twice.