Migrate DataTypeTest to SqlDataTypeTest in Phoenix5 #10471
Merged
hashhar merged 6 commits intotrinodb:masterfrom Jan 6, 2022
Merged
Migrate DataTypeTest to SqlDataTypeTest in Phoenix5 #10471hashhar merged 6 commits intotrinodb:masterfrom
hashhar merged 6 commits intotrinodb:masterfrom
Conversation
Additionally - Use REQUIRED_TPCH_TABLES in TestPhoenixConnectorTest - Do not load TPCH tables in TestPhoenixTypeMapping
Additionally - Move verification of timezone gap to setUp method - Use data provider to test session timezones - Add link to Phoenix official data types
Member
Author
|
CI hit #6220 |
hashhar
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6395
TestPhoenixTypeMapping between 4 and 5 were same before #10452. I simply applied the commits in the PR to
trino-phoenix5module.