Update examples for FROM_UNIXTIME_NANOS#10442
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Jan 1, 2022
Merged
Conversation
ebyhr
reviewed
Jan 1, 2022
Member
ebyhr
left a comment
There was a problem hiding this comment.
Let's use UTC as timezone so that we can understand the function's behavior quickly.
1970-01-01 00:00:00.000000100 UTC
1970-01-01 00:00:00.000001234 UTC
1970-01-01 00:00:00.000001234 UTC
1969-12-31 23:59:59.999998766 UTC
Member
Author
|
@ebyhr There are a couple more instances of timezone examples where they use a different timezone, should we modify those as well? For example, see Should be changed to UTC as well? |
ebyhr
approved these changes
Jan 1, 2022
Member
|
I think there is no need to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation originally stated that
FROM_UNIXTIME_NANOSwould yield a timestamp(9) with time zone, but the example output is not timezoned.