Skip to content

Fix ClassNotFoundException in StateCompiler#10408

Merged
dain merged 1 commit intotrinodb:masterfrom
dain:fix-state-compiler-CNF
Dec 25, 2021
Merged

Fix ClassNotFoundException in StateCompiler#10408
dain merged 1 commit intotrinodb:masterfrom
dain:fix-state-compiler-CNF

Conversation

@dain
Copy link
Copy Markdown
Member

@dain dain commented Dec 25, 2021

No description provided.

@cla-bot cla-bot bot added the cla-signed label Dec 25, 2021
@dain dain requested a review from martint December 25, 2021 00:02
@kokosing
Copy link
Copy Markdown
Member

kokosing commented Dec 25, 2021

Can we have product tests for this? It seems to be another problem with class loader recently and PT are great to ensure coverage for problem like this

@dain dain merged commit 9586ae2 into trinodb:master Dec 25, 2021
@dain dain deleted the fix-state-compiler-CNF branch December 25, 2021 22:02
@github-actions github-actions bot added this to the 368 milestone Dec 25, 2021
@findepi
Copy link
Copy Markdown
Member

findepi commented Dec 27, 2021

Quoting @findepi 's comment from #10346 ("Fix ClassNotFoundException in state compiler")

We should have a product test covering @realknorke 's case (#10341) to prevent regressions. I don't think we're able to effectively exercise classloader-related issues in a unit test manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants