Do not hold on to mutable config object#10382
Merged
findepi merged 1 commit intotrinodb:masterfrom Jan 5, 2022
Merged
Conversation
martint
reviewed
Dec 22, 2021
Member
There was a problem hiding this comment.
This is hard to read. Move the requireNonNull to a separate line (as it was before).
findepi
force-pushed
the
findepi/do-not-hold-on-to-mutable-config-object-51ddf9
branch
from
34d4dfe to
995c076
Compare
findepi
deleted the
findepi/do-not-hold-on-to-mutable-config-object-51ddf9
branch
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Jan 11, 2022
Cherry-pick of trinodb/trino#10382 Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.