Skip to content

Add reusable smoke test coverage for concurrent UPDATE#10368

Merged
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/test-concurrent-update
Jan 10, 2022
Merged

Add reusable smoke test coverage for concurrent UPDATE#10368
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/test-concurrent-update

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Dec 21, 2021

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why trinoException != e?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because trinoException == e implies that attaching e as suppressed is kind of pointless.
verifyConcurrentUpdateFailurePermissible should be rethrowing trinoException

@findepi findepi force-pushed the findepi/test-concurrent-update branch from 553ebf8 to a6377b8 Compare January 5, 2022 12:58
@findepi findepi marked this pull request as ready for review January 5, 2022 12:58
@findepi findepi force-pushed the findepi/test-concurrent-update branch 4 times, most recently from 285b10a to b9f63a7 Compare January 10, 2022 12:24
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@findepi findepi force-pushed the findepi/test-concurrent-update branch from b9f63a7 to cbac3c5 Compare January 10, 2022 12:26
@findepi findepi merged commit c8ded00 into trinodb:master Jan 10, 2022
@findepi findepi deleted the findepi/test-concurrent-update branch January 10, 2022 15:22
@github-actions github-actions bot added this to the 368 milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants