Add reusable smoke test coverage for concurrent UPDATE#10368
Merged
findepi merged 1 commit intotrinodb:masterfrom Jan 10, 2022
Merged
Add reusable smoke test coverage for concurrent UPDATE#10368findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
losipiuk
reviewed
Dec 21, 2021
Member
Author
There was a problem hiding this comment.
because trinoException == e implies that attaching e as suppressed is kind of pointless.
verifyConcurrentUpdateFailurePermissible should be rethrowing trinoException
losipiuk
approved these changes
Dec 21, 2021
553ebf8 to
a6377b8
Compare
285b10a to
b9f63a7
Compare
findepi
commented
Jan 10, 2022
b9f63a7 to
cbac3c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.